linux-kernel - Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240227224846c7846f20@mail.local>
Date: Tue, 27 Feb 2024 23:48:46 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: David Gow <davidgow@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Guenter Roeck <linux@...ck-us.net>, Rae Moar <rmoar@...gle.com>,
	Matthew Auld <matthew.auld@...el.com>,
	Arunpravin Paneer Selvam <arunpravin.paneerselvam@....com>,
	Christian König <christian.koenig@....com>,
	Kees Cook <keescook@...omium.org>,
	Maíra Canal <mcanal@...lia.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Matthew Brost <matthew.brost@...el.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Florian Westphal <fw@...len.de>,
	Cassio Neri <cassio.neri@...il.com>,
	Javier Martinez Canillas <javierm@...hat.com>,
	Arthur Grillo <arthur.grillo@....br>,
	Brendan Higgins <brendan.higgins@...ux.dev>,
	Daniel Latypov <dlatypov@...gle.com>,
	Stephen Boyd <sboyd@...nel.org>, David Airlie <airlied@...il.com>,
	Maxime Ripard <mripard@...nel.org>,
	"David S . Miller" <davem@...emloft.net>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	intel-xe@...ts.freedesktop.org, linux-rtc@...r.kernel.org,
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
	linux-hardening@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

On 27/02/2024 14:23:29-0700, Shuah Khan wrote:
> On 2/27/24 13:32, Alexandre Belloni wrote:
> > Hello,
> > 
> > On 21/02/2024 17:27:18+0800, David Gow wrote:
> > > 'days' is a s64 (from div_s64), and so should use a %lld specifier.
> > > 
> > > This was found by extending KUnit's assertion macros to use gcc's
> > > __printf attribute.
> > > 
> > > Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.")
> > > Signed-off-by: David Gow <davidgow@...gle.com>
> > 
> > Who do you expect to take this patch?
> > 
> 
> I am going to be applying this series to linux-kselftest kunit next
> in just a bit. Would you like to ack the pacth?

Sure,

Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> 
> thanks,
> -- Shuah
> 
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com