linux-kernel - Re: [PATCHv8 10/17] x86/tdx: Convert shared memory back to private on kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13ff89af-cee5-4102-be23-1c8ebd51f86d@intel.com>
Date: Wed, 28 Feb 2024 12:30:42 +1300
From: "Huang, Kai" <kai.huang@...el.com>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>
CC: "Rafael J. Wysocki" <rafael@...nel.org>, Peter Zijlstra
	<peterz@...radead.org>, Adrian Hunter <adrian.hunter@...el.com>, "Kuppuswamy
 Sathyanarayanan" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "Elena
 Reshetova" <elena.reshetova@...el.com>, Jun Nakajima
	<jun.nakajima@...el.com>, Rick Edgecombe <rick.p.edgecombe@...el.com>, Tom
 Lendacky <thomas.lendacky@....com>, "Kalra, Ashish" <ashish.kalra@....com>,
	"Sean Christopherson" <seanjc@...gle.com>, Baoquan He <bhe@...hat.com>,
	<kexec@...ts.infradead.org>, <linux-coco@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv8 10/17] x86/tdx: Convert shared memory back to private on
 kexec


>   
> +/* Stop new private<->shared conversions */
> +static void tdx_kexec_stop_conversion(bool crash)
> +{
> +	/*
> +	 * Crash kernel reaches here with interrupts disabled: can't wait for
> +	 * conversions to finish.
> +	 *
> +	 * If race happened, just report and proceed.
> +	 */
> +	bool wait_for_lock = !crash;
> +
> +	if (!stop_memory_enc_conversion(wait_for_lock))
> +		pr_warn("Failed to finish shared<->private conversions\n");

"Failed to finish" -> "Failed to stop"?  stop_memory_enc_conversion() 
doesn't actually finish any conversion.

Other than that:

Reviewed-by: Kai Huang <kai.huang@...el.com>