[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c5e041dc-42b0-86f2-aba3-28d4db305c38@quicinc.com>
Date: Tue, 27 Feb 2024 08:44:53 +0530
From: Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
Bjorn Andersson
<andersson@...nel.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring
<robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Rob Herring
<robh+dt@...nel.org>,
Johan Hovold <johan+linaro@...nel.org>,
Brian Masney
<bmasney@...hat.com>, Georgi Djakov <djakov@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-pci@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<vireshk@...nel.org>, <quic_vbadigan@...cinc.com>,
<quic_skananth@...cinc.com>, <quic_nitegupt@...cinc.com>,
<quic_parass@...cinc.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: Re: [PATCH v7 3/7] PCI: qcom: Add ICC bandwidth vote for CPU to PCIe
path
On 2/24/2024 5:32 AM, Konrad Dybcio wrote:
> On 23.02.2024 15:48, Krishna chaitanya chundru wrote:
>> To access PCIe registers, PCIe BAR space, config space the CPU-PCIe
>> ICC(interconnect consumers) path should be voted otherwise it may
>> lead to NoC(Network on chip) timeout. We are surviving because of
>> other driver vote for this path.
>> As there is less access on this path compared to PCIe to mem path
>> add minimum vote i.e 1KBps bandwidth always.
>>
>> In suspend remove the disable this path after register space access
>> is done.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>
>> ---
>
> [...]
>
>>
>> + /* Remove cpu path vote after all the register access is done */
>> + ret = icc_disable(pcie->icc_cpu);
>> + if (ret) {
>> + dev_err(dev, "failed to disable icc path of cpu-pcie: %d\n", ret);
>> + if (pcie->suspended) {
>> + qcom_pcie_host_init(&pcie->pci->pp);
>> + pcie->suspended = false;
>> + }
>> + qcom_pcie_icc_opp_update(pcie);
>
> This doesn't compile (you rename it in patch 6, this is patch 3)
>
> Konrad
>
I will fix this in my next series.
- Krishna Chaitanya.
Powered by blists - more mailing lists