linux-kernel - Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <CO6PR18MB4467EA7976DEDD6872D0BC54DE592@CO6PR18MB4467.namprd18.prod.outlook.com>
Date: Tue, 27 Feb 2024 07:36:16 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Subbaraya
 Sundeep Bhatta <sbhatta@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>
Subject: Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom
 information



> On Thu, 22 Feb 2024 22:45:42 +0530 Hariprasad Kelam wrote:
> > +	if (!ee->len || ((ee->len + ee->offset) > SFP_EEPROM_SIZE))
> > +		return -EINVAL;
> 
> Are you sure there's a path thru the core to the driver which would allow len
> == 0 or the size being larger than when info put in eeprom_len?

 Seems these checks are not necessary,  will remove these checks in next version.

Thanks,
Hariprasad k
> --
> pw-bot: cr