linux-kernel - Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_1407D9AC6F6B4411233FEAD6@qq.com>
Date: Tue, 27 Feb 2024 08:44:52 +0000
From: "关文涛" <guanwentao@...ontech.com>
To: "WANG Xuerui" <kernel@...0n.name>, "王昱力" <wangyuli@...ontech.com>, "davem" <davem@...emloft.net>, "chenhuacai" <chenhuacai@...nel.org>
Cc: "linux-crypto" <linux-crypto@...r.kernel.org>, "loongarch" <loongarch@...ts.linux.dev>, "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations

Okay, somehow i think Yuli the origin commit message some misleading
things,the whole story expand that origin mips/crypto/crc32-mips.c code 
"len -= sizeof(u32);" necessary only in "!CONFIG_64BIT" macro define,
they are just a "binary bit" game as we tran the number to binary bit,
while less and less one in 64bit ,the less thing we do if >=32bit do once,
>=16bit do once ... etc... If we delete the useless code line, it is very cool,
and unrelated to specific ISA. We also think maybe we need to add 
"#ifnef CONFIG_64BIT"in origin mips/crypto/crc32-mips.c "len -= sizeof(u32);",
but it add code instead of delete code...

Thanks.
Guan Wentao