linux-kernel - Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 10:06:41 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Charlie Jenkins
 <charlie@...osinc.com>, Palmer Dabbelt <palmer@...belt.com>, Erhard Furtner
 <erhard_f@...lbox.org>, Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S. Miller" <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs

On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
> Hi,
> 
> Le 23/02/2024 à 11:41, Christophe Leroy a écrit :
> > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
> > fixed endianness issues with kunit checksum tests, but then
> > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
> > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
> > are once again reflected by the warnings reported by sparse.
> > 
> > So, fix them with the same approach, perform proper conversion in
> > order to support both little and big endian CPUs. Once the conversions
> > are properly done and the right types used, the sparse warnings are
> > cleared as well.
> > 
> > Reported-by: Erhard Furtner <erhard_f@...lbox.org>
> > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
> > Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> netdev checkpatch complains about "1 blamed authors not CCed: 
> palmer@...osinc.com; 1 maintainers not CCed: palmer@...osinc.com "
> 
> Palmer was copied but as Palmer Dabbelt <palmer@...belt.com>. Hope it is 
> not a show stopper.

No, it's not.

Acked-by: Paolo Abeni <pabeni@...hat.com>

I *think* this, despite the subject prefix, should go via Andrew's tree
to avoid conflicts.

@Andrew does the above fits you?

Cheers,

Paolo