linux-kernel - Re: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 17:55:47 +0800
From: Kunwu Chan <chentao@...inos.cn>
To: manivannan.sadhasivam@...aro.org
Cc: chentao@...inos.cn,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mhi@...ts.linux.dev
Subject: Re: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

Thanks for the reply.
> > On Wed, Feb 21, 2024 at 04:59:37PM +0800, Kunwu Chan wrote:
> > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> > to simplify the creation of SLAB caches.
> > 
> 
> There are multiple instances of kmem_cache_create() in this driver. Could you
> change them also?

Sure, I'll change all of them if possible in v2 patch.

> 
> - Mani
> 
> > Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> > ---
> >  drivers/bus/mhi/ep/main.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> > index 65fc1d738bec..7b61d384b2b6 100644
> > --- a/drivers/bus/mhi/ep/main.c
> > +++ b/drivers/bus/mhi/ep/main.c
> > @@ -1493,9 +1493,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> >  		goto err_destroy_ev_ring_el_cache;
> >  	}
> >  
> > -	mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> > -							sizeof(struct mhi_ep_ring_item), 0,
> > -							0, NULL);
> > +	mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
> >  	if (!mhi_cntrl->ev_ring_el_cache) {
> >  		ret = -ENOMEM;
> >  		goto err_destroy_tre_buf_cache;
> > -- 
> > 2.39.2
> > 
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்
> 
 Thanks,
	Kunwu.Chan