linux-kernel - Re: [PATCH] arm64/kernel/setup: Update comment on interrupt masking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd21AaRO_JGLFo78@FVFF77S0Q05N>
Date: Tue, 27 Feb 2024 10:10:09 +0000
From: Mark Rutland <mark.rutland@....com>
To: takakura@...inux.co.jp
Cc: catalin.marinas@....com, will@...nel.org, ardb@...nel.org,
	rmk+kernel@...linux.org.uk, Jonathan.Cameron@...wei.com,
	gregkh@...uxfoundation.org, james.morse@....com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64/kernel/setup: Update comment on interrupt masking

On Sun, Feb 25, 2024 at 11:18:12AM +0900, takakura@...inux.co.jp wrote:
> From: Ryo Takakura <takakura@...inux.co.jp>
> 
> DAIF_PROCCTX_NOIRQ contains FIQ bit.
> Update the comment as only asynchronous aborts are unmasked
> and FIQ is still masked.
> 
> Signed-off-by: Ryo Takakura <takakura@...inux.co.jp>
> ---
>  arch/arm64/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 0ea45b6d0177..9b9fdb64c684 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
>  	dynamic_scs_init();
>  
>  	/*
> -	 * Unmask asynchronous aborts and fiq after bringing up possible
> +	 * Unmask asynchronous aborts after bringing up possible
>  	 * earlycon. (Report possible System Errors once we can report this
>  	 * occurred).
>  	 */

I think we can further simplify/clarify that as:

	/*
	 * Unmask SError as soon as possible after initializing earlycon so
	 * that we can report any SErrors immediately.
	 */

With that wording:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.