| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <92b9e9ac-6265-4611-888d-ba74bb871be5@baylibre.com>
Date: Tue, 27 Feb 2024 11:23:26 +0100
From: Alexandre Mergnat <amergnat@...libre.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
<matthias.bgg@...il.com>, Lee Jones <lee@...nel.org>,
Flora Fu <flora.fu@...iatek.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Sumit Semwal <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-media@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 02/18] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add
audio sound card document
On 26/02/2024 16:30, AngeloGioacchino Del Regno wrote:
> Il 26/02/24 15:01, Alexandre Mergnat ha scritto:
>> Add soundcard bindings for the MT8365 SoC with the MT6357 audio codec.
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
>> ---
>> .../bindings/sound/mediatek,mt8365-mt6357.yaml | 127
>> +++++++++++++++++++++
>> 1 file changed, 127 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/sound/mediatek,mt8365-mt6357.yaml
>> b/Documentation/devicetree/bindings/sound/mediatek,mt8365-mt6357.yaml
>> new file mode 100644
>> index 000000000000..f469611ec6b6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8365-mt6357.yaml
>> @@ -0,0 +1,127 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/mediatek,mt8365-mt6357.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Mediatek MT8365 sound card with MT6357 sound codec.
>> +
>> +maintainers:
>> + - Alexandre Mergnat <amergnat@...libre.com>
>> +
>> +description:
>> + This binding describes the MT8365 sound card.
>> +
>> +properties:
>> + compatible:
>> + const: mediatek,mt8365-mt6357
>> +
>> + mediatek,hp-pull-down:
>> + description:
>> + Earphone driver positive output stage short to the
>> + audio reference ground.
>> + Default value is false.
>> + type: boolean
>> +
>> + mediatek,micbias0-microvolt:
>> + description: |
>
> description: Selects MIC Bias 0 output voltage
>
>> + Selects MIC Bias 0 output voltage.
>> + [1.7v, 1.8v, 1.9v, 2.0v, 2.1v, 2.5v, 2.6v, 2.7v]
>> + enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> No, you don't say 0 1 2 3 4 to a property that says "microvolt", that's
> simply
> wrong.
>
> mediatek,micbias0-microvolt = <2100000>;
>
> ...so you want a binding that says
> enum: [ 1700000, 1800000, this, that, 2700000]
>
Is it correct if I put "description: Selects MIC Bias 0 output voltage
index" ?
>> +
>> + mediatek,micbias1-microvolt:
>> + description: |
>> + Selects MIC Bias 1 output voltage.
>> + [1.7v, 1.8v, 1.9v, 2.0v, 2.1v, 2.5v, 2.6v, 2.7v]
>> + enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> same here.
>
>> +
>> + mediatek,platform:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: The phandle of MT8365 ASoC platform.
>> +
>> + pinctrl-names:
>> + minItems: 1
>> + items:
>> + - const: aud_default
>> + - const: aud_dmic
>> + - const: aud_miso_off
>> + - const: aud_miso_on
>> + - const: aud_mosi_off
>> + - const: aud_mosi_on
>> +
>> + vaud28-supply:
>> + description:
>> + 2.8 volt supply for the audio codec
>> +
>> +patternProperties:
>> + "^dai-link-[0-9]+$":
>> + type: object
>> + description:
>> + Container for dai-link level properties and CODEC sub-nodes.
>> +
>> + properties:
>> + codec:
>> + type: object
>> + description: Holds subnode which indicates codec dai.
>> +
>> + properties:
>> + sound-dai:
>> + maxItems: 1
>> + description: phandle of the codec DAI
>> +
>> + additionalProperties: false
>> +
>> + link-name:
>> + description:
>> + This property corresponds to the name of the BE dai-link to
>> which
>> + we are going to update parameters in this node.
>> + items:
>> + const: 2ND I2S BE
>> +
>> + sound-dai:
>> + maxItems: 1
>> + description: phandle of the CPU DAI
>> +
>> + additionalProperties: false
>> +
>> + required:
>> + - link-name
>> + - sound-dai
>> +
>> +additionalProperties: false
>> +
>> +required:
>> + - compatible
>> + - mediatek,platform
>> + - pinctrl-names
>> + - vaud28-supply
>> +
>> +examples:
>> + - |
>> + sound {
>> + compatible = "mediatek,mt8365-mt6357";
>> + mediatek,platform = <&afe>;
>
> Please:
>
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Is it about the wrong pinctrl-names tab alignment ?
Also, 2ND I2S BE => 2ND_I2S_BE ?
Otherwise, I don't get it sorry.
>
> Regards,
> Angelo
>
>> + pinctrl-names = "aud_default",
>> + "aud_dmic",
>> + "aud_miso_off",
>> + "aud_miso_on",
>> + "aud_mosi_off",
>> + "aud_mosi_on";
>> + pinctrl-0 = <&aud_default_pins>;
>> + pinctrl-1 = <&aud_dmic_pins>;
>> + pinctrl-2 = <&aud_miso_off_pins>;
>> + pinctrl-3 = <&aud_miso_on_pins>;
>> + pinctrl-4 = <&aud_mosi_off_pins>;
>> + pinctrl-5 = <&aud_mosi_on_pins>;
>> + vaud28-supply = <&mt6357_vaud28_reg>;
>> +
>> + /* hdmi interface */
>> + dai-link-0 {
>> + sound-dai = <&afe>;
>> + link-name = "2ND I2S BE";
>> +
>> + codec {
>> + sound-dai = <&it66121hdmitx>;
>> + };
>> + };
>> + };
>>
>
--
Regards,
Alexandre
Powered by blists - more mailing lists