linux-kernel - Re: [PATCH] hwrng: hisi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240227122046.00006c97@Huawei.com>
Date: Tue, 27 Feb 2024 12:20:46 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Martin Kaiser <martin@...ser.cx>
CC: Herbert Xu <herbert@...dor.apana.org.au>, <linux-crypto@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwrng: hisi - use dev_err_probe

On Mon, 26 Feb 2024 19:57:00 +0100
Martin Kaiser <martin@...ser.cx> wrote:

> Replace dev_err + return with dev_err_probe.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Maybe worth wrapping the line in this subsystem still strives for
<= 80 chars


> ---
>  drivers/char/hw_random/hisi-rng.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index b6f27566e0ba..4e501d5c121f 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -89,10 +89,8 @@ static int hisi_rng_probe(struct platform_device *pdev)
>  	rng->rng.read = hisi_rng_read;
>  
>  	ret = devm_hwrng_register(&pdev->dev, &rng->rng);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to register hwrng\n");
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "failed to register hwrng\n");


















>  
>  	return 0;
>  }