linux-kernel - Re: [PATCH] riscv: Fix definition of _PAGE_NOCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c030391-d8df-45aa-b4e2-73c45fbd1d97@intel.com>
Date: Tue, 27 Feb 2024 20:47:18 +0800
From: "Wu, Fei" <fei2.wu@...el.com>
To: Alexandre Ghiti <alex@...ti.fr>, <paul.walmsley@...ive.com>,
	<palmer@...belt.com>, <aou@...s.berkeley.edu>, <guoren@...nel.org>,
	<jszhang@...nel.org>, <linux-riscv@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: Fix definition of _PAGE_NOCACHE_THEAD

On 2/27/2024 8:44 PM, Alexandre Ghiti wrote:
> Hi Fei,
> 
> On 27/02/2024 13:44, Fei Wu wrote:
>> _PAGE_NOCACHE_THEAD is not used but the definition is wrong.
>>
>> Signed-off-by: Fei Wu <fei2.wu@...el.com>
>> ---
>>   arch/riscv/include/asm/pgtable-64.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/include/asm/pgtable-64.h
>> b/arch/riscv/include/asm/pgtable-64.h
>> index b42017d76924..b99bd66107a6 100644
>> --- a/arch/riscv/include/asm/pgtable-64.h
>> +++ b/arch/riscv/include/asm/pgtable-64.h
>> @@ -136,7 +136,7 @@ enum napot_cont_order {
>>    * 10010 - IO   Strongly-ordered, Non-cacheable, Non-bufferable,
>> Shareable, Non-trustable
>>    */
>>   #define _PAGE_PMA_THEAD        ((1UL << 62) | (1UL << 61) | (1UL <<
>> 60))
>> -#define _PAGE_NOCACHE_THEAD    ((1UL < 61) | (1UL << 60))
>> +#define _PAGE_NOCACHE_THEAD    ((1UL << 61) | (1UL << 60))
>>   #define _PAGE_IO_THEAD        ((1UL << 63) | (1UL << 60))
>>   #define _PAGE_MTMASK_THEAD    (_PAGE_PMA_THEAD | _PAGE_IO_THEAD |
>> (1UL << 59))
>>   
> 
> 
> This fix is already in -fixes:
> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?id=c21f014818600ae017f97ee087e7c136b1916aa7
> 
Thank you Alex, got it.

Fei.

> Thanks,
> 
> Alex
>