linux-kernel - Re: [PATCH] firmware_loader: Use init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 04:59:59 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: russ.weight@...ux.dev, gregkh@...uxfoundation.org, rafael@...nel.org,
	linux-kernel@...r.kernel.org, masahiroy@...nel.org
Subject: Re: [PATCH] firmware_loader: Use init_utsname()->release

On Mon, Feb 26, 2024 at 05:13:44PM +0000, John Garry wrote:
> On 26/02/2024 17:10, Luis Chamberlain wrote:
> > > > I am running this now, but it does not seem stable on a v6.8-rc5 baseline. I
> > > > am seeing hangs. Are there any known issues?
> > > I tested next-20240108 and so no issues.
> > > 
> > > Lemme upgrade.
> > > 
> > > Note you also need /lib/udev/rules.d/50-firmware.rules removed if
> > > you have it.
> 
> I have this:
> ubuntu@...rry-ubuntu-bm5-instance-20230215-1843:~/mnt/linux2$ more
> /lib/udev/rules.d/50-firmware.rules
> # stub for immediately telling the kernel that userspace firmware loading
> # failed; necessary to avoid long timeouts with
> CONFIG_FW_LOADER_USER_HELPER=y
> SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1"
> 
> So I can remove it.

You can keep it on a distro use case, but for testing it is important to
remove it.

> > I don't see any hung tasks on next-20240226. Perhaps its with your
> > config that it is triggered.
> OK, I'll check again when I get a chance, but I am not so keen on checking
> linux-next in general.

What kernel are you seeing this issue on?

  Luis