linux-kernel - Re: [PATCH v2 3/3] platform/x86: intel_scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53ba6c16-f0af-44ee-73c5-f6b983ed6420@linux.intel.com>
Date: Tue, 27 Feb 2024 15:06:37 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Armin Wolf <W_Armin@....de>
cc: Shyam-sundar.S-k@....com, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>, 
    sathyanarayanan.kuppuswamy@...ux.intel.com, 
    Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu
 static

On Fri, 23 Feb 2024, Armin Wolf wrote:

> The variable is only used internally and has no external users,
> so it should me made static.
> 
> Compile-tested only.
> 
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---
> Changes since v1:
> - remove Fixes tag
> - add Reviewed-by tag
> ---
>  drivers/platform/x86/intel_scu_ipcutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c
> index b7c10c15a3d6..7d87cbd4b9c6 100644
> --- a/drivers/platform/x86/intel_scu_ipcutil.c
> +++ b/drivers/platform/x86/intel_scu_ipcutil.c
> @@ -22,7 +22,7 @@
> 
>  static int major;
> 
> -struct intel_scu_ipc_dev *scu;
> +static struct intel_scu_ipc_dev *scu;
>  static DEFINE_MUTEX(scu_lock);
> 
>  /* IOCTL commands */

Thanks, I took this 3/3 and 1/3 into review-ilpo.

Please check the comment I raised against 2/3.

-- 
 i.