linux-kernel - Re: [PATCH v6 2/2] media: i2c: Add GC08A3 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd3jG2HC3mR0dQR3@kekkonen.localdomain>
Date: Tue, 27 Feb 2024 13:26:51 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Zhi Mao <zhi.mao@...iatek.com>, mchehab@...nel.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org,
	laurent.pinchart@...asonboard.com, shengnan.wang@...iatek.com,
	yaya.chang@...iatek.com, 10572168@...com,
	Project_Global_Chrome_Upstream_Group@...iatek.com,
	yunkec@...omium.org, conor+dt@...nel.org, matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com,
	jacopo.mondi@...asonboard.com, hverkuil-cisco@...all.nl,
	heiko@...ech.de, jernej.skrabec@...il.com, macromorgan@...mail.com,
	linus.walleij@...aro.org, hdegoede@...hat.com,
	tomi.valkeinen@...asonboard.com, gerald.loacker@...fvision.net,
	bingbu.cao@...el.com, dan.scally@...asonboard.com,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v6 2/2] media: i2c: Add GC08A3 image sensor driver

Hi Andy,

On Tue, Feb 27, 2024 at 02:46:54PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2024 at 3:33 AM Zhi Mao <zhi.mao@...iatek.com> wrote:
> >
> > Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.
> 
> ...
> 
> > +/*
> > + * gc08a3.c - gc08a3 sensor driver
> 
> Drop the filename from the file, it's impractical (esp. if the file
> will be renamed for some reason in the future).
> 
> > + *
> > + * Copyright 2023 MediaTek

You could update the year.

..

> 
> > +       endpoint =
> > +               fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 0, 0,
> > +                                               FWNODE_GRAPH_ENDPOINT_NEXT);
> > +       if (!endpoint) {
> 
> Strictly speaking dev_fwnode(dev) might be NULL or an error pointer. I
> dunno how the graph is implemented there and if it's possible to get
> an error pointer out of it. At least this probably needs to be aligned
> there at some point.

This is fine---the fwnode API returns errors (for functions that can) for
NULL or error pointer fwnodes.

The patches are in my tree already, please post a patch on top of this that
I can squash.

-- 
Regards,

Sakari Ailus