linux-kernel - Re: [PATCH] s390/vfio-ap: handle hardware checkstop state on queue reset operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 15:29:17 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: "Jason J. Herne" <jjherne@...ux.ibm.com>
Cc: linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        pasic@...ux.ibm.com, akrowiak@...ux.ibm.com, borntraeger@...ibm.com,
        agordeev@...ux.ibm.com, gor@...ux.ibm.com
Subject: Re: [PATCH] s390/vfio-ap: handle hardware checkstop state on queue
 reset operation

On Tue, Feb 27, 2024 at 08:25:21AM -0500, Jason J. Herne wrote:
> Polite Ping :)
> 
> Patch already has R-b.
> Thanks for taking a look.
> 
> On 2/15/24 10:31 AM, Jason J. Herne wrote:
> > Update vfio_ap_mdev_reset_queue() to handle an unexpected checkstop (hardware error) the
> > same as the deconfigured case. This prevents unexpected and unhelpful warnings in the
> > event of a hardware error.
> > 
> > We also stop lying about a queue's reset response code. This was originally done so we
> > could force vfio_ap_mdev_filter_matrix to pass a deconfigured device through to the guest
> > for the hotplug scenario. vfio_ap_mdev_filter_matrix is instead modified to allow
> > passthrough for all queues with reset state normal, deconfigured, or checkstopped. In the
> > checkstopped case we choose to pass the device through and let the error state be
> > reflected at the guest level.
> > 
> > Signed-off-by: Jason J. Herne <jjherne@...ux.ibm.com>
> > Reviewed-by: Anthony Krowiak <akrowiak@...ux.ibm.com>
> > ---
> >   drivers/s390/crypto/vfio_ap_ops.c | 35 ++++++++++++++++---------------
> >   1 file changed, 18 insertions(+), 17 deletions(-)

Applied, thanks!