linux-kernel - Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd9WU1bpoOlR9de7@nanopsycho>
Date: Wed, 28 Feb 2024 16:50:43 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Lena Wang (王娜) <Lena.Wang@...iatek.com>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"dsahern@...nel.org" <dsahern@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Shiming Cheng (成诗明) <Shiming.Cheng@...iatek.com>
Subject: Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed

Wed, Feb 28, 2024 at 04:38:56PM CET, Lena.Wang@...iatek.com wrote:
>From: Shiming Cheng <shiming.cheng@...iatek.com>
>
>When rule policy is changed, ipv6 socket cache is not refreshed.
>The sock's skb still uses a outdated route cache and was sent to
>a wrong interface.
>
>To avoid this error we should update fib node's version when
>rule is changed. Then skb's route will be reroute checked as
>route cache version is already different with fib node version.
>The route cache is refreshed to match the latest rule.
>
>Signed-off-by: Shiming Cheng <shiming.cheng@...iatek.com>
>Signed-off-by: Lena Wang <lena.wang@...iatek.com>

1) You are still missing Fixes tags, I don't know what to say.
2) Re patch subject:
   "ipv6:flush ipv6 route cache when rule is changed"
   Could it be:
   "ipv6: fib6_rules: flush route cache when rule is changed"
   ? please.
3) Could you please honor the 24h hours resubmission rule:
https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html#tl-dr

pw-bot: cr