[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240228-nifty-flashy-shrew-905edc@houat>
Date: Wed, 28 Feb 2024 17:16:48 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Maíra Canal <mcanal@...lia.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Jonathan Corbet <corbet@....net>,
Sandy Huang <hjc@...k-chips.com>, Heiko Stübner <heiko@...ech.de>,
Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>, Hans Verkuil <hverkuil@...all.nl>,
Sebastian Wick <sebastian.wick@...hat.com>, Ville Syrjälä <ville.syrjala@...ux.intel.com>,
dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH v7 29/36] drm/vc4: tests: Remove vc4_dummy_plane structure
On Tue, Feb 27, 2024 at 07:45:01PM -0300, Maíra Canal wrote:
> Hi Maxime,
>
> On 2/27/24 10:02, Maxime Ripard wrote:
> > Hi Maíra,
> >
> > Thanks for you reviews!
> >
> > On Mon, Feb 26, 2024 at 09:29:32AM -0300, Maíra Canal wrote:
> > > On 2/22/24 15:14, Maxime Ripard wrote:
> > > > The vc4_dummy_plane structure is an exact equivalent to vc4_plane, so we
> > >
> > > Maybe I understood incorrectly, but isn't the vc4_dummy_plane structure
> > > equivalent to drm_plane?
> >
> > Both statements are true :)
> >
> > vc4 itself uses vc4_plane to holds its plane-related content, but it
> > turns out that there's nothing in that structure anymore and vc4_plane
> > == drm_plane.
> >
> > In our mock driver, we have another structure meant to store the
> > mock-plane-related content which doesn't have anything in it anymore,
> > and is thus equivalent to vc4_plane.
> >
> > So, basically, vc4_dummy_plane == vc4_plane == drm_plane.
> >
> > This patch is only about getting rid of vc4_dummy_plane though.
> >
> > Is it clearer?
> >
>
> Yeah, with that pointed out, you can add my:
I'll rephrase for the next version then
> Reviewed-by: Maíra Canal <mcanal@...lia.com>
Thanks!
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists