linux-kernel - Re: [RFC PATCH 1/1] v4l2-core: rewrite the VP9 library in Rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28f4-65df7480-b-5f6f8180@243208659>
Date: Wed, 28 Feb 2024 17:59:35 +0000
From: "Daniel Almeida" <daniel.almeida@...labora.com>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: wedsonaf@...il.com, ojeda@...nel.org, mchehab@...nel.org, hverkuil@...all.nl, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, kernel@...labora.com
Subject: Re: [RFC PATCH 1/1] v4l2-core: rewrite the VP9 
 library in Rust

Hi Alice!

On Wednesday, February 28, 2024 11:13 -03, Alice Ryhl <aliceryhl@...glecom> wrote:

> I recommend taking an `*mut u8` here instead of `&mut u8` if you're
> going to use `slice::from_raw_parts_mut`. Or, if cbindgen allows it,
> take an `&mut [u8; 8]` instead and eliminate the unsafe block.

You're right, the signature here can change to `&mut [u8; 8]` instead. This means no unsafe blocks at all.

Thanks for the tip,

-- Daniel