linux-kernel - Re: [PATCH] PCI/sysfs: Fix race in pci sysfs creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240228181618.GA14383@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Wed, 28 Feb 2024 10:16:18 -0800
From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
To: Krzysztof Wilczyński <kwilczynski@...nel.org>
Cc: Bjorn Helgaas <helgaas@...nel.org>, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	alexander.stein@...tq-group.com, decui@...rosoft.com
Subject: Re: [PATCH] PCI/sysfs: Fix race in pci sysfs creation

On Thu, Feb 29, 2024 at 02:22:55AM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> Sorry for late reply.
> 
> [...]
> > > > > Krzysztof has done a ton of work to convert these files to static
> > > > > attributes, where the device model prevents most of these races:
> > > > > 
> > > > >   506140f9c06b ("PCI/sysfs: Convert "index", "acpi_index", "label" to static attributes")
> > > > >   d93f8399053d ("PCI/sysfs: Convert "vpd" to static attribute")
> > > > >   f42c35ea3b13 ("PCI/sysfs: Convert "reset" to static attribute")
> > > > >   527139d738d7 ("PCI/sysfs: Convert "rom" to static attribute")
> > > > >   e1d3f3268b0e ("PCI/sysfs: Convert "config" to static attribute")
> > > > > 
> > > > > and he even posted a series to do the same for the resource files:
> > > > > 
> > > > >   https://lore.kernel.org/linux-pci/20210910202623.2293708-1-kw@linux.com/
> > > > > 
> > > > > I can't remember why we didn't apply that at the time, and it no
> > > > > longer applies cleanly, but I think that's the direction we should go.
> > > > 
> > > > Thanks for you review.
> > > > 
> > > > Please inform me if there's existing feedback explaining why this
> > > > series hasn't been merged yet. I am willing to further improve it
> > > > if necessary.
> > > 
> > > Let us know your opinion so that we can move ahead in fixing this
> > > long pending bug.
> 
> I really thought you were asking me about your patch.  So, I didn't reply
> since Bjorn added his review.
> 
> > There's no feedback on the mailing list (I checked the link above), so
> > the way forward is to update the series so it applies cleanly again
> > and post it as a v3.
> 
> Start with a review, if you have some time.  Perhaps we can make it better
> before sending another revision.
> 
> There are two areas which this series decided not to tackle initially:
> 
>   - Support for the Alpha platform
>   - Support for legacy PCI platforms
> 
> Feel free to have a look at the above.  Perhaps you will have some ideas on how
> to best convert both of these to use static attributes, so that we could convert
> everything at the same time.
> 
> > There's no need to wait for Krzysztof to refresh it, and if you have
> > time to do it, it would be very welcomed!  The best base would be
> > v6.8-rc1.
> 
> That I can do, perhaps this coming weekend.  Or even sooner when I find some
> time this week.
> 
> 	Krzysztof

Thank you ! I will look forward to it. I am happy to review and offer
contributions if required.

- Saurabh