linux-kernel - Re: [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240228183227.1822982-1-florian.fainelli@broadcom.com>
Date: Wed, 28 Feb 2024 10:32:27 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: bcm-kernel-feedback-list@...adcom.com,
	Arnd Bergmann <arnd@...nel.org>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>
Cc: Florian Fainelli <f.fainelli@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: bcm: stop selecing CONFIG_TICK_ONESHOT

From: Florian Fainelli <f.fainelli@...il.com>

On Wed, 28 Feb 2024 13:38:42 +0100, Arnd Bergmann <arnd@...nel.org> wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> ARCH_BCM_MOBILE is the only platform that selects CONFIG_TICK_ONESHOT,
> the others stopped 12 years ago in commit 98fab064d321 ("ARM: Remove
> unnecessary selection of TICK_ONESHOT").
> 
> This inconsistency caused a build regression after an otherwise
> correct change to the timers subsystem:
> 
> kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying'
>  1599 | void tick_sched_timer_dying(int cpu)
>       |      ^
> kernel/time/tick-sched.h:111:20: note: previous definition is here
>   111 | static inline void tick_sched_timer_dying(int cpu) { }
> 
> Drop this dead select.
> 
> Fixes: 3aedb7fcd88a ("tick/sched: Remove useless oneshot ifdeffery")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian