linux-kernel - Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d666668b-f371-47e0-846e-6e8a56b4bb2f@alliedtelesis.co.nz>
Date: Wed, 28 Feb 2024 20:01:29 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Rob Herring <robh@...nel.org>
CC: "andy@...nel.org" <andy@...nel.org>, "geert@...ux-m68k.org"
	<geert@...ux-m68k.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "andrew@...n.ch" <andrew@...n.ch>,
	"gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
	"sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
	"ojeda@...nel.org" <ojeda@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "javierm@...hat.com" <javierm@...hat.com>,
	"robin@...tonic.nl" <robin@...tonic.nl>, "lee@...nel.org" <lee@...nel.org>,
	"pavel@....cz" <pavel@....cz>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-leds@...r.kernel.org"
	<linux-leds@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic
 7 segment LED


On 29/02/24 03:04, Rob Herring wrote:
> On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote:
>> Add bindings for a generic 7 segment LED display using GPIOs.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
>> Notes:
>>      Changes in v2:
>>      - Use compatible = "generic-gpio-7seg" to keep http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLskYi3hWDQ&u=http%3a%2f%2fcheckpatch%2epl happy
>>
>>   .../auxdisplay/generic-gpio-7seg.yaml         | 40 +++++++++++++++++++
>>   1 file changed, 40 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
>> new file mode 100644
>> index 000000000000..46d53ebdf413
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/auxdisplay/generic-gpio-7seg.yaml
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLsYdhCQAWQ&u=http%3a%2f%2fdevicetree%2eorg%2fschemas%2fauxdisplay%2fgeneric%2cgpio-7seg%2eyaml%23
>> +$schema: http://scanmail.trustwave.com/?c=20988&d=7b3f5fUJGtY-Kala5ZOOxaOVYt2BwN-ZLsYY0X9WDg&u=http%3a%2f%2fdevicetree%2eorg%2fmeta-schemas%2fcore%2eyaml%23
>> +
>> +title: GPIO based LED segment display
>> +
>> +maintainers:
>> +  - Chris Packham <chris.packham@...iedtelesis.co.nz>
>> +
>> +properties:
>> +  compatible:
>> +    const: generic-gpio-7seg
> 'generic' doesn't add anything of value. 7seg is kind of vague. So,
> gpio-7-segment?

Ack.

>> +
>> +  segment-gpios:
>> +    description:
>> +      An array of GPIOs one per segment.
>> +    minItems: 7
> How does one know which GPIO is which segment?

I've expanded the description in v3.

+ An array of GPIOs one per segment. The first GPIO corresponds to the A
+ segment the last GPIO corresponds to the G segment.

Do you think that's sufficient or do I need to add more? In the driver 
itself I've put a little ascii art diagram of the segments.