linux-kernel - Re: [PATCH] docs: submit-checklist: structure by category

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 14:57:19 -0700
From: Jonathan Corbet <corbet@....net>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>, workflows@...r.kernel.org,
 linux-doc@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Lukas
 Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH] docs: submit-checklist: structure by category

Lukas Bulwahn <lukas.bulwahn@...il.com> writes:

> While going through the submit checklist, the list order seemed rather
> random, probably just by historical coincidences of always adding yet the
> next point someone thought of at the end of the list.
>
> Structure and order them by the category of such activity,
> reviewing, documenting, checking with tools, building and testing.

So this is clearly a step in the right direction, so I'm not opposed to
it.  But I do have a couple of thoughts:

- This document is old and unloved.  Its age shows in a lot of ways
  (wmb() rather than the sorts of barriers that are socially acceptable
  in 2024, for example).  It makes no mention of the CI systems that
  should get their say for a lot of subsystems; nor does it mention the
  subsystem-specific maintainer profiles that should also be
  consulted. And so on.  It needs a lot of work rather than a
  reshuffling.  (But, as I say, the reshuffling is an improvement, so
  I'll take it).

- It's a bit of an awkward fit with submitting-patches.rst.  Someday
  we'll have a set of coherent docs, maybe.

Anyway, I'm done grumbling now...:)  I'll look forward to v2 -
preferably soon; I have travel coming up and may need to cut things off
for 6.9 a bit earlier than usual.

Thanks,

jon