linux-kernel - Re: [PATCH v3] clkdev: Update clkdev id usage to allow for longer names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24963d5f5a964f7620a4aa1cf5769d62.sboyd@kernel.org>
Date: Wed, 28 Feb 2024 14:14:48 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Michael J. Ruhl <michael.j.ruhl@...el.com>, linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Russell King <linux@...linux.org.uk>, Michael Turquette <mturquette@...libre.com>, andriy.shevchenko@...ux.intel.com, Michael J. Ruhl <michael.j.ruhl@...el.com>, Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH v3] clkdev: Update clkdev id usage to allow for longer names

Quoting Michael J. Ruhl (2024-02-23 12:25:56)
> clkdev DEV ID information is limited to an array of 20 bytes
> (MAX_DEV_ID).  It is possible that the ID could be longer than
> that.  If so, the lookup will fail because the "real ID" will
> not match the copied value.
> 
> For instance, generating a device name for the I2C Designware
> module using the PCI ID can result in a name of:
> 
> i2c_designware.39424
> 
> clkdev_create() will store:
> 
> i2c_designware.3942
> 
> The stored name is one off and will not match correctly during probe.
> 
> Increase the size of the ID to allow for a longer name.
> 
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@...el.com>
> ---

Applied to clk-next