linux-kernel - Re: [PATCH v2 0/4] auxdisplay: 7 segment LED display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 00:25:30 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: "andy@...nel.org" <andy@...nel.org>, "geert@...ux-m68k.org"
	<geert@...ux-m68k.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "andrew@...n.ch"
	<andrew@...n.ch>, "gregory.clement@...tlin.com"
	<gregory.clement@...tlin.com>, "sebastian.hesselbarth@...il.com"
	<sebastian.hesselbarth@...il.com>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "javierm@...hat.com"
	<javierm@...hat.com>, "robin@...tonic.nl" <robin@...tonic.nl>,
	"lee@...nel.org" <lee@...nel.org>, "pavel@....cz" <pavel@....cz>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 0/4] auxdisplay: 7 segment LED display


On 28/02/24 13:05, Andy Shevchenko wrote:
> On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
> <chris.packham@...iedtelesis.co.nz> wrote:
>> This series adds a driver for a 7 segment LED display.
>>
>> At this point I've decided not to pursue supporting >1 character. I had
>> a look at what would be required to add a devm_fwnode_gpiod_get_array()
>> and got bogged down in OF and ACPI code for counting GPIOs.
> Out of curiosity, why did it happen? gpiod_count() works in an agnostic way.
>
At first I though I could create a fwnode_gpiod_count() out of the body 
of gpiod_count(). But both of_gpio_get_count() and acpi_gpio_count() 
take the dev not the fwnode. It looks like gpiod_count() (and 
of_gpio_spi_cs_get_count()) could probably be re-written (or abstracted) 
to take the device_node instead of the device. I started looking at 
acpi_gpio_count() but I couldn't quite see how I could adapt this.

I'm definitely not saying it can't be done. Just that you probably don't 
want an occasional contributor like me messing with some of these core 
device abstractions.