linux-kernel - Re: [PATCH v2] mm/zsmalloc: don't need to reserve LSB in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240228032633.GD11972@google.com>
Date: Wed, 28 Feb 2024 12:26:33 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Chengming Zhou <chengming.zhou@...ux.dev>
Cc: minchan@...nel.org, senozhatsky@...omium.org, akpm@...ux-foundation.org,
	hannes@...xchg.org, nphamcs@...il.com, yosryahmed@...gle.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/zsmalloc: don't need to reserve LSB in handle

On (24/02/28 02:38), Chengming Zhou wrote:
> We will save allocated tag in the object header to indicate that it's
> allocated.
> 
> 	handle |= OBJ_ALLOCATED_TAG;
> 
> So the object header needs to reserve LSB for this tag bit.
> 
> But the handle itself doesn't need to reserve LSB to save tag, since
> it's only used to find the position of object, by (pfn + obj_idx).
> So remove LSB reserve from handle, one more bit can be used as obj_idx.
> 
> Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>

Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>