linux-kernel - Re: [PATCH 2/2] xfs: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 27 Feb 2024 20:02:05 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: chandan.babu@...cle.com, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH 2/2] xfs: Remove duplicate include

On Wed, Feb 28, 2024 at 11:56:12AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  fs/xfs/xfs_trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 1a963382e5e9..23e906b60f21 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -17,7 +17,6 @@
>  #include "xfs_btree.h"
>  #include "xfs_da_btree.h"
>  #include "xfs_alloc.h"
> -#include "xfs_bmap.h"

Shouldn't this remove the second #include?

--D

>  #include "xfs_attr.h"
>  #include "xfs_trans.h"
>  #include "xfs_log.h"
> -- 
> 2.20.1.7.g153144c
> 
>