linux-kernel - RE: [PATCH v2 vfio 2/2] vfio/pds: Refactor/simplify reset logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276CD4BF00814779A22CF1F8C582@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Wed, 28 Feb 2024 04:55:52 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Brett Creeley <brett.creeley@....com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "shannon.nelson@....com" <shannon.nelson@....com>
Subject: RE: [PATCH v2 vfio 2/2] vfio/pds: Refactor/simplify reset logic

> From: Brett Creeley <brett.creeley@....com>
> Sent: Wednesday, February 28, 2024 8:32 AM
> 
> The current logic for handling resets is more complicated than it needs
> to be. The deferred_reset flag is used to indicate a reset is needed
> and the deferred_reset_state is the requested, post-reset, state. The
> source of the requested reset isn't immediately obvious. Improve
> readability by replacing deferred_reset_state with deferred_reset_type,
> which can be either PDS_VFIO_DEVICE_RESET (initiated/requested by the
> DSC) or PDS_VFIO_HOST_RESET (initiated/requested by the VMM).
> 
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Reviewed-by: Shannon Nelson <shannon.nelson@....com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>