linux-kernel - Re: [PATCH 0/2] Fix per-policy boost behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c165dd32-1e51-2fac-38ae-dd7300d36372@quicinc.com>
Date: Wed, 28 Feb 2024 10:44:46 +0530
From: Sibi Sankar <quic_sibis@...cinc.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
CC: <dietmar.eggemann@....com>, <marcan@...can.st>, <sven@...npeter.dev>,
        <alyssa@...enzweig.io>, <rafael@...nel.org>, <xuwei5@...ilicon.com>,
        <zhanjie9@...ilicon.com>, <sudeep.holla@....com>,
        <cristian.marussi@....com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_rgottimu@...cinc.com>,
        <linux-arm-kernel@...ts.infradead.org>, <asahi@...ts.linux.dev>,
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 0/2] Fix per-policy boost behavior

On 2/28/24 10:37, Viresh Kumar wrote:
> On 27-02-24, 22:23, Sibi Sankar wrote:
>> Fix per-policy boost behavior by incorporating per-policy boost flag
>> in the policy->max calculation and setting the correct per-policy
>> boost_enabled value on devices that use cpufreq_enable_boost_support().
> 
> I don't see the problem explained anywhere and the patches look
> incorrect too. The drivers aren't supposed to update the
> policy->boose_enabled value.

Hey Viresh,
Thanks for taking time to review the series.

In the existing code, per-policy flags doesn't have any impact i.e.
if cpufreq_driver boost is enabled and one or more of the per-policy
boost is disabled, the cpufreq driver will behave as if boost is
enabled. I had to update the policy->boost_enabled value because we seem
to allow enabling cpufreq_driver.boost_enabled from the driver, but I
can drop that because it was just for book keeping. I didn't want
to include redundant info from another mail thread that I referenced in
the cover letter, but will add more info in the re-spin.

-Sibi

>