linux-kernel - Re: [PATCH] dax: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11abf2aca138b389d7ab5c2d6b75d82fb6b1bddc.camel@intel.com>
Date: Wed, 28 Feb 2024 05:32:45 +0000
From: "Verma, Vishal L" <vishal.l.verma@...el.com>
To: "chengming.zhou@...ux.dev" <chengming.zhou@...ux.dev>, "Jiang, Dave"
	<dave.jiang@...el.com>, "Williams, Dan J" <dan.j.williams@...el.com>
CC: "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
	"nvdimm@...ts.linux.dev" <nvdimm@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dax: remove SLAB_MEM_SPREAD flag usage

On Wed, 2024-02-28 at 11:16 +0800, Chengming Zhou wrote:
> On 2024/2/28 00:29, Dave Jiang wrote:
> > 
> > 
> > On 2/24/24 6:47 AM, chengming.zhou@...ux.dev wrote:
> > > From: Chengming Zhou <zhouchengming@...edance.com>
> > > 
> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > > its usage so we can delete it from slab. No functional change.
> > 
> > Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
> 
> Update changelog to make it clearer:
> 
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
> 
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
> 
> Thanks!

With the updated changelog, you can add

Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>

> 
> > > 
> > > Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> > > ---
> > >  drivers/dax/super.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> > > index 54e528779877..cff0a15b7236 100644
> > > --- a/drivers/dax/super.c
> > > +++ b/drivers/dax/super.c
> > > @@ -547,7 +547,7 @@ static int dax_fs_init(void)
> > >  
> > >  	dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
> > >  			(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> > > -			 SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> > > +			 SLAB_ACCOUNT),
> > >  			init_once);
> > >  	if (!dax_cache)
> > >  		return -ENOMEM;