linux-kernel - Re: [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ccab1ca-428b-4812-b46a-671e816dd34d@amd.com>
Date: Wed, 28 Feb 2024 07:51:36 +0100
From: Christian König <christian.koenig@....com>
To: Lu Yao <yaolu@...inos.cn>, alexander.deucher@....com, Xinhui.Pan@....com,
 airlied@...il.com, daniel@...ll.ch
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Fix assignment errors in
 'si_common_early_init' functions

Am 28.02.24 um 02:44 schrieb Lu Yao:
> uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.

Yeah, but that is completely irrelevant here. We usually don't use the & 
for function pointers since that is unnecessary in C.

Regards,
Christian.

>
> Signed-off-by: Lu Yao <yaolu@...inos.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index a757526153e5..455d49f7bd9c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
>   	adev->pcie_wreg = &si_pcie_wreg;
>   	adev->pciep_rreg = &si_pciep_rreg;
>   	adev->pciep_wreg = &si_pciep_wreg;
> -	adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
> -	adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
> +	adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
> +	adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
>   	adev->didt_rreg = NULL;
>   	adev->didt_wreg = NULL;
>