linux-kernel - Re: [PATCH] Net:cache didn't flush when ipv6 rule changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34a1ca43d2f21428367237b4b693df6804bf716d.camel@redhat.com>
Date: Wed, 28 Feb 2024 08:34:49 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Lena Wang (王娜) <Lena.Wang@...iatek.com>,
  "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
 <kuba@...nel.org>,  "dsahern@...nel.org" <dsahern@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Shiming
	Cheng (成诗明)
	 <Shiming.Cheng@...iatek.com>
Subject: Re: [PATCH] Net:cache didn't flush when ipv6 rule changed

Hi,

On Wed, 2024-02-28 at 07:28 +0000, Lena Wang (王娜) wrote:
> Dear David,
> Update the patch as below, thanks.
> 
> 
> From db01a40e45f51d00cb19e45a41507c97363d6ed8 Mon Sep 17 00:00:00 2001
> From: shiming cheng <shiming.cheng@...iatek.com>
> Date: Mon, 26 Feb 2024 20:17:58 +0800
> Subject: [PATCH] Net:cache didn't flush when ipv6 rule changed
> 
> When changed from old rule&route configure to new one as below,
> ipv6 cache dst_entry did not change to new route table as no
> cache flush callback function, then forward to wrong out interface.
> When fib6_check dst_entry, the fib6_node version[fn_sernm] is
> always the same with socket dst_cookie, old cache dst_entry is
> always used and no chance to update.
> 
> So we need to update fib6_node version when rule changed and
> flush cache to avoid dispatching a wrong interface.
> 
> Signed-off-by: shiming cheng <shiming.cheng@...iatek.com>

You need to cc the netdev mailing list to allow up processing the
patch.

Please also include the target tree in the subject prefix ('net' in
this case), a suitable fixes tag and avoid sending patches in reply to
existing threads as it confuses our bot.

@David (out of sheer ignorace) could this the root cause for the fib6
self-tests sporadic failures?

Thanks,

Paolo