linux-kernel - Re: [PATCH] mm/zsmalloc: move get_zspage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2a988e3-892d-4dd8-b75f-96d76c89ee6b@bytedance.com>
Date: Wed, 28 Feb 2024 17:45:01 +0800
From: Chengming Zhou <zhouchengming@...edance.com>
To: Arnd Bergmann <arnd@...nel.org>, Minchan Kim <minchan@...nel.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Arnd Bergmann <arnd@...db.de>, Nhat Pham <nphamcs@...il.com>,
 Domenico Cerasuolo <cerasuolodomenico@...il.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/zsmalloc: move get_zspage_lockless into #ifdef

On 2024/2/28 17:40, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> It's only used from inside of an #ifdef section, causing a warning otherwise:
> 
> mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function]
>   735 | static struct zspage *get_zspage_lockless(struct page *page)
>       |                       ^~~~~~~~~~~~~~~~~~~
> 
> Move it down into that block to avoid adding another #ifdef.
> 
> Fixes: 2258bdebb55e ("mm/zsmalloc: don't hold locks of all pages when free_zspage()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hello Arnd,

Thanks for your fix! But this series has problem and should be removed by Andrew later[1][2].

[1] https://lore.kernel.org/all/20240228043534.GG11972@google.com/
[2] https://lore.kernel.org/all/20240228035403.GE11972@google.com/

Thanks!