linux-kernel - RE: [EXT] Re: [net-next PatchV3] octeontx2-pf: Add support to read eeprom information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB4474F9F96EDDC1FD22E1B5F9DE582@PH0PR18MB4474.namprd18.prod.outlook.com>
Date: Wed, 28 Feb 2024 10:45:02 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>
Subject: RE: [EXT] Re: [net-next PatchV3] octeontx2-pf: Add support to read
 eeprom information


> On Tue, Feb 27, 2024 at 02:17:22PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
> > Usage: ethtool -m <interface>
> >
> > Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> > Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> > ---
> > V3 * remove redundant checks as stack is already doing it.
> 
> So still only access to the first 256 bytes, using the old internal API.
> 
Firmware and Kernel shares the data over a shared memory region. 

  Firmware   <-- Shared memory -->   Kernel

As per our design, firmware updates the shared memory region by reading eeprom data from the MAC. 
Upon receiving ethtool request to read eeprom data, Kernel maps this shared memory and copies the eeprom data to the user.

Currently firmware supports updating only the first page of eeprom. Due to this we are limited to support the first page.

, using the old internal API.

While copying the data, the current patch does considers the offset/length fields.
         ethtool -m ethx offset x length x

Could please point us what are we missing here?

Thanks,
Hariprasad k


> Disappointing.
> 
> And the Signed-of-by: appear to be in the wrong order.
> 
>     Andrew