linux-kernel - Re: [PATCH v8 02/10] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZGRSWQT1FZ0.2YQ0R8UD86L2U@bootlin.com>
Date: Wed, 28 Feb 2024 15:09:46 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Rob Herring" <robh@...nel.org>
Cc: <linux-gpio@...r.kernel.org>, <linux-mips@...r.kernel.org>,
 <linux-clk@...r.kernel.org>, "Gregory CLEMENT"
 <gregory.clement@...tlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@...ileye.com>, "Vladimir Kondratiev"
 <vladimir.kondratiev@...ileye.com>, "Linus Walleij"
 <linus.walleij@...aro.org>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski@...aro.org>, "Stephen Boyd" <sboyd@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@...aro.org>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>, "Rob Herring" <robh+dt@...nel.org>, "Philipp
 Zabel" <p.zabel@...gutronix.de>, Rafał Miłecki
 <rafal@...ecki.pl>, "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Michael Turquette" <mturquette@...libre.com>
Subject: Re: [PATCH v8 02/10] dt-bindings: soc: mobileye: add EyeQ5 OLB
 system controller

Hello,

On Tue Feb 27, 2024 at 5:38 PM CET, Rob Herring wrote:
> On Tue, 27 Feb 2024 15:55:23 +0100, Théo Lebrun wrote:
> > Add documentation to describe the "Other Logic Block" syscon.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> > ---
> >  .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml  | 94 ++++++++++++++++++++++
> >  1 file changed, 94 insertions(+)
> > 
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/clock/mobileye,eyeq5-clk.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.example.dtb: system-controller@...000: clock-controller@2c: False schema does not allow {'compatible': ['mobileye,eyeq5-clk'], 'reg': [[44, 80], [284, 4]], 'reg-names': ['plls', 'ospi'], '#clock-cells': [[1]], 'clocks': [[4294967295]], 'clock-names': ['ref']}
> 	from schema $id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.example.dtb: system-controller@...000: reset-controller@0: False schema does not allow {'compatible': ['mobileye,eyeq5-reset'], 'reg': [[0, 12], [512, 52], [288, 4]], 'reg-names': ['d0', 'd1', 'd2'], '#reset-cells': [[2]]}
> 	from schema $id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml#
> Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.exampledtb: /example-0/soc/system-controller@...000/reset-controller@0: failed to match any schema with compatible: ['mobileye,eyeq5-reset']
> Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.exampledtb: /example-0/soc/system-controller@...000/clock-controller@2c: failed to match any schema with compatible: ['mobileye,eyeq5-clk']

This series depends on 4 patches from previous revisions that got taken
into clk-next. Those are v6.8-rc1..clk-mobileye on the clk remote [0].

Without the 4 patches I've reproduced the above warning; it disappears
once they are applied.

Have a nice day,

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/log/?h=clk-mobileye

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com