[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9b06003c-afc9-419a-af36-7b81aab8517e@lunn.ch>
Date: Wed, 28 Feb 2024 16:04:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@....cz>,
Lee Jones <lee@...nel.org>,
Richard Cochran <richardcochran@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-leds@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
herve.codina@...tlin.com, maxime.chevallier@...tlin.com,
christophercordahi@...ometrics.ca
Subject: Re: [PATCH v2 3/6] net: phy: DP83640: Add LED handling
> +static int dp83640_led_brightness_set(struct phy_device *phydev, u8 index,
> + enum led_brightness brightness)
> +{
> + int val;
> +
> + if (index > DP83640_SPDLED_IDX)
> + return -EINVAL;
> +
> + phy_write(phydev, PAGESEL, 0);
> +
> + val = phy_read(phydev, LEDCR) & ~DP83640_LED_DIS(index);
> + val |= DP83640_LED_DRV(index);
> + if (brightness)
> + val |= DP83640_LED_VAL(index);
> + else
> + val &= ~DP83640_LED_VAL(index);
> + phy_write(phydev, LEDCR, val);
I don't understand this driver too well, but should this be using
ext_read() and ext_write().
I'm also woundering if it would be good to implement the .read_page
and .write_page members in phy_driver and then use phy_write_paged()
and phy_write_paged() and phy_modify_paged(), which should do better
locking.
Andrew
Powered by blists - more mailing lists