linux-kernel - Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240229064742.36c2f476@kernel.org>
Date: Thu, 29 Feb 2024 06:47:42 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Tasmiya Nalatwad <tasmiya@...ux.vnet.ibm.com>, Vadim Fedorenko
 <vadim.fedorenko@...ux.dev>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, arkadiusz.kubalewski@...el.com,
 jiri@...dia.com, "abdhalee@...ux.vnet.ibm.com"
 <abdhalee@...ux.vnet.ibm.com>, "mputtash@...ux.vnet.com"
 <mputtash@...ux.vnet.com>, "sachinp@...ux.vnet.com"
 <sachinp@...ux.vnet.com>, venkat88@...ux.vnet.ibm.com,
 "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
> I do not see other solution than this, otherwise we have to add more
> pollution to include/linux/netdevice.h

Right :(

> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a9c973b92294bb110cf3cd336485972127b01b58..40797ea80bc6273cae6b7773d0a3e47459a72150
> 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2469,7 +2469,7 @@ struct net_device {
>         struct devlink_port     *devlink_port;
> 
>  #if IS_ENABLED(CONFIG_DPLL)
> -       struct dpll_pin __rcu   *dpll_pin;
> +       void __rcu *dpll_pin;
>  #endif

If DPLL wants to hide its type definitions the helpers must live
in dpll? IOW move netdev_dpll_pin() to drivers/dpll/dpll_core.c

BTW Tasmiya, please do tell us what compiler you're using.