linux-kernel - Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fa04f9a-2904-4955-a219-d4962b8fe41b@sirena.org.uk>
Date: Thu, 29 Feb 2024 14:49:16 +0000
From: Mark Brown <broonie@...nel.org>
To: Esteban Blanc <eblanc@...libre.com>
Cc: Bhargav Raviprakash <bhargav.r@...s.com>, linux-kernel@...r.kernel.org,
	m.nirmaladevi@...s.com, lee@...nel.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	jpanis@...libre.com, devicetree@...r.kernel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, lgirdwood@...il.com,
	linus.walleij@...aro.org, linux-gpio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, nm@...com, vigneshr@...com,
	kristo@...nel.org
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224
 PMIC regulators

On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote:
> On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote:

> > +	/* Number of interrupts supported by each voltage source */
> > +	interrupt_cnt = (tps->chip_id == TPS6594) ?
> > +			 ARRAY_SIZE(tps6594_buck1_irq_types) :
> > +			 ARRAY_SIZE(tps65224_buck1_irq_types);

> The comment is not adding anything, the name is clear and ARRAY_SIZE is
> quite explicit.

Also please don't abuse the ternery operator like this, write normal
conditionals or for a case like this where we may get more options in
future use switch statements.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)