linux-kernel - Re: [PATCH v2 1/2] gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeCcoYb8gTRGQTku@smile.fi.intel.com>
Date: Thu, 29 Feb 2024 17:02:57 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Subject: Re: [PATCH v2 1/2] gpiolib-of: Make of_gpio_get_count() take
 firmware node as a parameter

On Thu, Feb 29, 2024 at 04:51:38PM +0200, Andy Shevchenko wrote:
> Make of_gpio_get_count() take firmware node as a parameter in order
> to be aligned with other functions and decouple from unused device
> pointer. The latter helps to create a common fwnode_gpio_count()
> in the future.
> 
> While at it, rename to be of_gpio_count() to be aligned with the others.

..

>  struct device;
> +struct fwnode_handle;

I just realized that this should be replacement, not addition.

 -struct device;
 +struct fwnode_handle;

Bart, tell me if you can update, or should I send a v3?

-- 
With Best Regards,
Andy Shevchenko