[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <43840914-cb4a-4758-9691-0ebd8fb97681@gmail.com>
Date: Thu, 29 Feb 2024 17:08:40 +0200
From: "Ceclan, Dumitru" <mitrutzceclan@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, David Lechner <dlechner@...libre.com>,
Ceclan Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for
additional models
On 29/02/2024 16:49, Krzysztof Kozlowski wrote:
> On 28/02/2024 14:54, Dumitru Ceclan wrote:
>> Add support for: AD7172-2, AD7175-8, AD7177-2.
>> AD7172-4 does not feature an internal reference, check for external
>> reference presence.
..
>> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
>
> There is no such file in next-20240229.
>
It's not yet accepted
https://lore.kernel.org/all/20240228110622.25114-1-mitrutzceclan@gmail.com/
..
>> + # Model ad7172-4 does not support internal reference
>> + # mandatory to have an external reference
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: adi,ad7172-4
>> + then:
>> + patternProperties:
>> + "^channel@[0-9a-f]$":
>> + properties:
>> + adi,reference-select:
>> + enum:
>> + - vref
>> + - vref2
>> + - avdd
>> + required:
>> + - adi,reference-select
>
> Are you defining properties here? I cannot verify because this file does
> not exist in next.
>
No, just constraining reference-select to be required and exclude
"refout-avss".
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists