linux-kernel - Re: [PATCH md-6.9 v3 00/11] md/raid1: refactor read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4da77457-6eb7-1977-4686-28e4a7aab8e2@huaweicloud.com>
Date: Thu, 29 Feb 2024 09:14:38 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Song Liu <song@...nel.org>, Yu Kuai <yukuai1@...weicloud.com>
Cc: xni@...hat.com, paul.e.luse@...ux.intel.com, shli@...com, neilb@...e.com,
 linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 yi.zhang@...wei.com, yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.9 v3 00/11] md/raid1: refactor read_balance() and
 some minor fix

Hi,

在 2024/02/29 5:23, Song Liu 写道:
> On Wed, Feb 28, 2024 at 3:49 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
>>
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> Changes in v3:
>>   - add patch 2, and fix that setup_conf() is missing in patch3;
>>   - add some review tag from Xiao Ni(other than patch 2,3);
> 
> It appears that v3 causes mdadm test "01replace" to run forever.
> I haven't figured out why, but v2 doesn't seem to have this issue.

I'm running tests while sending this version, and I found that too this
morning. :(

I'll check out what's wrong and update soon.

Thanks,
Kuai

> 
> Thanks,
> Song
> 
>> Changes in v2:
>>   - add new conter in conf for patch 2;
>>   - fix the case choose next idle while there is no other idle disk in
>>   patch 3;
>>   - add some review tag from Xiao Ni for patch 1, 4-8
>>
>> The original idea is that Paul want to optimize raid1 read
>> performance([1]), however, we think that the original code for
>> read_balance() is quite complex, and we don't want to add more
>> complexity. Hence we decide to refactor read_balance() first, to make
>> code cleaner and easier for follow up.
> 
> .
>