linux-kernel - Re: [PATCH v3 2/2] Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 18:38:01 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Daniel Drake <drake@...lessos.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, tglx@...utronix.de, 
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, 
	hpa@...or.com, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bhelgaas@...gle.com, david.e.box@...ux.intel.com, mario.limonciello@....com, 
	rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux@...lessos.org, Jian-Hong Pan <jhp@...lessos.org>
Subject: Re: [PATCH v3 2/2] Revert "ACPI: PM: Block ASUS B1400CEAE from
 suspend to idle by default"

On Wed, Feb 28, 2024 at 11:26 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> [+to Rafael]
>
> On Wed, Feb 28, 2024 at 08:53:16AM +0100, Daniel Drake wrote:
> > This reverts commit d52848620de00cde4a3a5df908e231b8c8868250, which
> > was originally put in place to work around a s2idle failure on this
> > platform where the NVMe device was inaccessible upon resume.
> >
> > After extended testing, we found that the firmware's implementation of
> > S3 is buggy and intermittently fails to wake up the system. We need
> > to revert to s2idle mode.
> >
> > The NVMe issue has now been solved more precisely in the commit titled
> > "PCI: Disable D3cold on Asus B1400 PCI-NVMe bridge"
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215742
> > Acked-by: Jian-Hong Pan <jhp@...lessos.org>
> > Signed-off-by: Daniel Drake <drake@...lessos.org>
>
> Rafael, if you're OK with this, I can queue both patches for v6.9.

Yes, please!

Feel free to add

Acked-by: Rafael J. Wysocki <rafael@...nel.org

to both.

Thanks!