linux-kernel - Re: (subset) [PATCH] leds: fix ifdef check for gpio_led_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170922859684.1626996.4061581947298770912.b4-ty@kernel.org>
Date: Thu, 29 Feb 2024 17:43:16 +0000
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>, Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Andrew Lunn <andrew@...n.ch>, 
 Christian Marangi <ansuelsmth@...il.com>, 
 "David S. Miller" <davem@...emloft.net>, 
 Jacek Anaszewski <jacek.anaszewski@...il.com>, 
 Hans de Goede <hdegoede@...hat.com>, 
 Jean-Jacques Hiblot <jjhiblot@...phandler.com>, 
 Heiner Kallweit <hkallweit1@...il.com>, linux-leds@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: (subset) [PATCH] leds: fix ifdef check for
 gpio_led_register_device()

On Wed, 28 Feb 2024 10:38:26 +0100, Arnd Bergmann wrote:
> gpio_led_register_device() is built whenever CONFIG_LEDS_GPIO_REGISTER is
> enabled, and this may be used even when CONFIG_NEW_LEDS is turned off.
> 
> However, the stub declaration in the header is provided for all configs
> without CONFIG_NEW_LEDS, resulting in a build failure:
> 
> drivers/leds/leds-gpio-register.c:24:1: error: redefinition of 'gpio_led_register_device'
>    24 | gpio_led_register_device(int id, const struct gpio_led_platform_data *pdata)
>       | ^
> include/linux/leds.h:646:39: note: previous definition is here
> 
> [...]

Applied, thanks!

[1/1] leds: fix ifdef check for gpio_led_register_device()
      commit: 71c65d0ff79e3b21cb3eba67d87159533daaadbc

--
Lee Jones [李琼斯]