linux-kernel - Re: [PATCH v3] Watchdog: New module for ITE 5632 watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06bf41c9-34b8-4361-a6d9-72afeddae1b4@roeck-us.net>
Date: Thu, 29 Feb 2024 10:47:38 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Mark Pearson <mpearson@...ebb.ca>, David Ober <dober6023@...il.com>,
 wim@...ux-watchdog.org
Cc: linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
 David Ober <dober@...ovo.com>
Subject: Re: [PATCH v3] Watchdog: New module for ITE 5632 watchdog

On 2/29/24 10:12, Mark Pearson wrote:
[ ... ]

>> Is it necessary to treat this differently than, say,
>> drivers/hwmon/it87.c and drivers/watchdog/it87_wdt.c ?
>> Those work together nicely because most of the address space is
>> separate; access through Super-IO registers
>> is limited enough that it can be shared by using request_muxed_region()
>> in both drivers.
>>
>> I'll have to look deeper into NCT6692D (and NCT6686, for that matter),
>> to see if those require mfd drivers.
>> I'll also need to get the datasheets for those chips and confirm that
>> they really need different watchdog
>> drivers to start with.
>>
> Ack - I'll look at those and see. Quick look at the watchdog driver and it looks possible but I need to check the details more carefully.
> Afraid I can't share the datasheet as I don't have permission to release it. How much of a blocker is that for you?
> 

I do have the datasheet for the NCT6683 EC space. I'll need to check if
it matches the code submitted for the NCT6686 watchdog.

For NCT6692D, I asked Nuvoton if they can share the datasheet.
Given that it is some kind of security controller chip, it may well be
that Lenovo has an NDA with Nuvoton which prevents them from sharing
the datasheet. We'll see.

Undocumented ITE chips are simply not supportable. No matter what, someone
will have to step up as maintainer for those chips.

Guenter