linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180: Disable DCC node by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Xba76ZER=rqWm8H6dQTgkTRM38Edi81Y8-QXETvsmDCw@mail.gmail.com>
Date: Wed, 28 Feb 2024 17:50:44 -0800
From: Doug Anderson <dianders@...omium.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Konrad Dybcio <konrad.dybcio@...aro.org>, Bjorn Andersson <andersson@...nel.org>, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev, 
	linux-arm-msm@...r.kernel.org, cros-qcom-dts-watchers@...omium.org, 
	Souradeep Chowdhury <quic_schowdhu@...cinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Disable DCC node by default

Hi,

On Wed, Feb 28, 2024 at 5:35 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> We don't use this device on Trogdor boards. If we did, it would be
> enabled in the sc7180-trogdor.dtsi file. Let's disable this here so that
> boards with t he sc7180 SoC can decide to enable or disable this device.

s/t he/the/


> Cc: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
> Fixes: add74cad7c9d ("arm64: dts: qcom: sc7180: Add Data Capture and Compare(DCC) support node")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Seems fine to me. I guess the driver never landed, but if/when it
lands then it makes sense to just enable the device it for boards that
need it.

Reviewed-by: Douglas Anderson <dianders@...omium.org>