linux-kernel - Re: [PATCH v2 2/2] devres: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9b2ce52569b2c6a745ca3efa678fa83adfe0fac.camel@redhat.com>
Date: Thu, 29 Feb 2024 21:21:43 +0100
From: Philipp Stanner <pstanner@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>, Rasmus Villemoes
	 <linux@...musvillemoes.dk>, pstanner@...hat.com
Subject: Re: [PATCH v2 2/2] devres: Don't use "proxy" headers

Wait a second..

On Thu, 2024-02-29 at 17:53 +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.

Hm, what tree is this based on?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  lib/devres.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/devres.c b/lib/devres.c
> index 27f280a39dca..4fc152de6d8b 100644
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -1,10 +1,13 @@
>  // SPDX-License-Identifier: GPL-2.0
> +#include <linux/bug.h>
>  #include <linux/device.h>

Where does device.h come from?
That's not on master, is it? (see below).

Is this based on my PCI-devres series?

> -#include <linux/err.h>
> -#include <linux/io.h>
> -#include <linux/gfp.h>
> +#include <linux/errno.h>
>  #include <linux/export.h>
> +#include <linux/gfp_types.h>
> +#include <linux/io.h>
> +#include <linux/ioport.h>
>  #include <linux/of_address.h>
> +#include <linux/types.h>
>  
>  enum devm_ioremap_type {
>         DEVM_IOREMAP = 0,

That's what's currently in Linus's master:

// SPDX-License-Identifier: GPL-2.0
#include <linux/err.h>
#include <linux/pci.h>
#include <linux/io.h>
#include <linux/gfp.h>
#include <linux/export.h>
#include <linux/of_address.h>

enum devm_ioremap_type {



P.