linux-kernel - Re: [PATCH v2] kconfig: menuconfig: Make hidden options show with different color

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASjnwOcybuag62LkCQZGg73Dpa--jkfgtnB-r1Z=2Xqsw@mail.gmail.com>
Date: Thu, 29 Feb 2024 10:58:35 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Tomasz Figa <tfiga@...omium.org>
Cc: linux-kbuild@...r.kernel.org, Nicolas Schier <n.schier@....de>, 
	linux-kernel@...r.kernel.org, Jesse Taube <Mr.Bossman075@...il.com>
Subject: Re: [PATCH v2] kconfig: menuconfig: Make hidden options show with
 different color

On Wed, Feb 28, 2024 at 3:00 PM Tomasz Figa <tfiga@...omium.org> wrote:
>
> When hidden options are toggled on (using 'z'), the number of options
> on the screen can be overwhelming and may make it hard to distinguish
> between available and hidden ones. Make them easier to distinguish by
> displaying the hidden one with a different color (COLOR_YELLOW for color
> themes and A_DIM for mono).
>
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> ---


> diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
> index 3f78fb265136..161224dd6fb5 100644
> --- a/scripts/kconfig/lxdialog/util.c
> +++ b/scripts/kconfig/lxdialog/util.c
> @@ -38,6 +38,8 @@ static void set_mono_theme(void)
>         dlg.menubox_border.atr = A_NORMAL;
>         dlg.item.atr = A_NORMAL;
>         dlg.item_selected.atr = A_REVERSE;
> +       dlg.item_hidden.atr = A_NORMAL | A_DIM;


Nit.


(A_NORMAL | A_DIM) should be A_DIM.


A_NORMAL is zero.

Other A_* attributes are bit flags that can be OR'ed.




--
Best Regards
Masahiro Yamada