linux-kernel - Re: [PATCH] cgroup/cpuset: Fix retval in update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZeDrQzU29SlKU2hF@slm.duckdns.org>
Date: Thu, 29 Feb 2024 10:38:27 -1000
From: Tejun Heo <tj@...nel.org>
To: Kamalesh Babulal <kamalesh.babulal@...cle.com>
Cc: Waiman Long <longman@...hat.com>, Zefan Li <lizefan.x@...edance.com>,
	Tom Hromatka <tom.hromatka@...cle.com>, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup/cpuset: Fix retval in update_cpumask()

On Thu, Feb 29, 2024 at 03:41:14PM +0530, Kamalesh Babulal wrote:
> The update_cpumask(), checks for newly requested cpumask by calling
> validate_change(), which returns an error on passing an invalid set
> of cpu(s). Independent of the error returned, update_cpumask() always
> returns zero, suppressing the error and returning success to the user
> on writing an invalid cpu range for a cpuset. Fix it by returning
> retval instead, which is returned by validate_change().
> 
> Fixes: 99fe36ba6fc1 ("cgroup/cpuset: Improve temporary cpumasks handling")
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>

Applied to cgroup/for-6.8-fixes.

Thanks.

-- 
tejun