linux-kernel - RE: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 02:17:41 +0000
From: JiaJie Ho <jiajie.ho@...rfivetech.com>
To: 'Rob Herring' <robh@...nel.org>
CC: 'Herbert Xu' <herbert@...dor.apana.org.au>, "'David S . Miller'"
	<davem@...emloft.net>, 'Krzysztof Kozlowski'
	<krzysztof.kozlowski+dt@...aro.org>, 'Conor Dooley' <conor+dt@...nel.org>,
	'Eugeniy Paltsev' <Eugeniy.Paltsev@...opsys.com>, 'Vinod Koul'
	<vkoul@...nel.org>, "'linux-crypto@...r.kernel.org'"
	<linux-crypto@...r.kernel.org>, "'devicetree@...r.kernel.org'"
	<devicetree@...r.kernel.org>, "'linux-kernel@...r.kernel.org'"
	<linux-kernel@...r.kernel.org>, "'dmaengine@...r.kernel.org'"
	<dmaengine@...r.kernel.org>
Subject: RE: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support

> > Add compatible string and additional interrupt for StarFive JH8100
> > crypto engine.
> >
> > Signed-off-by: Jia Jie Ho <jiajie.ho@...rfivetech.com>
> > ---
> >  .../crypto/starfive,jh7110-crypto.yaml        | 30 +++++++++++++++++--
> >  1 file changed, 28 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > index 71a2876bd6e4..d44d77908966 100644
> > ---
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.
> > +++ yaml
> > @@ -12,7 +12,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: starfive,jh7110-crypto
> > +    enum:
> > +      - starfive,jh8100-crypto
> > +      - starfive,jh7110-crypto
> >
> >    reg:
> >      maxItems: 1
> > @@ -28,7 +30,10 @@ properties:
> >        - const: ahb
> >
> >    interrupts:
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: SHA2 module irq
> > +      - description: SM3 module irq
> >
> >    resets:
> >      maxItems: 1
> > @@ -54,6 +59,27 @@ required:
> >
> >  additionalProperties: false
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: starfive,jh7110-crypto
> > +
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 1
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: starfive,jh8100-crypto
> > +
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 2
> 
> This is already the max. Don't you want 'minItems: 2'?

I'll fix this in the next version.
Thanks for reviewing this.

Regards,
Jia Jie