linux-kernel - Re: [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add IFF_UNICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240228200516.1166a097@kernel.org>
Date: Wed, 28 Feb 2024 20:05:16 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Sanjuán García, Jorge"
 <Jorge.SanjuanGarcia@...gon.com>
Cc: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "s-vadapalli@...com" <s-vadapalli@...com>, "r-gunasekaran@...com"
 <r-gunasekaran@...com>, "rogerq@...nel.org" <rogerq@...nel.org>,
 "andrew@...n.ch" <andrew@...n.ch>, "f.fainelli@...il.com"
 <f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add
 IFF_UNICAST_FLT flag to port device

On Wed, 28 Feb 2024 11:13:23 +0000 Sanjuán García, Jorge wrote:
> Since commit 8940e6b669ca ("net: dsa: avoid call to __dev_set_promiscuity()
> while rtnl_mutex isn't held") when conecting one of this switch's port
> to a DSA switch as the conduit interface, the network interface is set to
> promiscuous mode by default and cannot be set to not promiscuous mode again
> from userspace. The reason for this is that the cpsw ports net devices
> do not have the flag IFF_UNICAST_FLT set in their private flags.
> 
> The cpsw switch should be able to set not promiscuous mode as otherwise
> a '1' is written to bit ALE_PORT_MACONLY_CAF which makes ethernet frames
> get an additional VLAN tag when entering the port connected to the DSA
> switch. Setting the IFF_UNICAST_FLT flag to all ports allows us to have
> the conduit interface on the DSA subsystem set as not promiscuous.

It doesn't look like am65-cpsw-nuss supports unicast filtering, 
tho, does it? So we're lying about support to work around some 
CPSW weirdness (additional VLAN tag thing)?