linux-kernel - Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <757d3977-4bac-47b8-a8b1-9bb84618895d@intel.com>
Date: Thu, 29 Feb 2024 09:06:34 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Alban Boyé <alban.boye@...tonmail.com>,
	<pierre-louis.bossart@...ux.intel.com>, <broonie@...nel.org>,
	<linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add an extra entry for the
 Chuwi Vi8 tablet

On 2024-02-28 8:28 PM, Alban Boyé wrote:
> The bios version can differ depending if it is a dual-boot variant of the tablet.
> Therefore another DMI match is required.
> 
> Signed-off-by: Alban Boyé <alban.boye@...tonmail.com>
> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 03be5e26ec4a..05f38d1f7d82 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_SSP0_AIF1 |
>   					BYT_RT5640_MCLK_EN),
>   	},
> +	{	/* Chuwi Vi8 dual-boot (CWI506) */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
> +			/* The above are too generic, also match BIOS info */
> +			DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
> +		},
> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> +					BYT_RT5640_MONO_SPEAKER |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{
>   		/* Chuwi Vi10 (CWI505) */
>   		.matches = {

Thank you for addressing the review comments.

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>